[OPA Plugin] Support splitting OPA filter requests in batch mode by batch size

[thinaih]

Description

This PR aims to address issue #25748

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( X ) Release notes are required. Please propose a release note for me.
() Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Thinhinane Ihadadene.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[thinaih]

The CI seems to be failing due to a missing JAVA_HOME environment variable, I'd appreciate if someone could help with this.

[Praveen2112]

Can we avoid using this abstraction and rather have these values explicitly like

assertAccessControlMethodBehaviour(situation1);
assertAccessControlMethodBehaviour(situation2);
...

So it is easier to understand on what are the impacts

[thinaih]

Do you mind clarifying if you mean the TestCase abstraction or ExpectedRequestProperties? I assume you mean TestCase

[mosiac1]

From what I've seen in previous PRs, what Praveen is refering to is doing something like

@Test
public void testFilterViewQueryOwnedBy()
{
    ...
    assertFilterViewQueryOwnedBy(new TestCase(OPA_CONFIG_NO_BATCH_SIZE, ImmutableMap.of(11, 1), 1));
    ...
}

void assertFilterViewQueryOwnedBy(TestCase testCase)
{
            assertAccessControlMethodBehaviour(
                    (accessControl, systemSecurityContext, identities) -> accessControl.filterViewQueryOwnedBy(systemSecurityContext.getIdentity(), identities),
                    inputIdentities,
                    identityToJsonNode,
                    new ExpectedRequestProperties(
                            testCase.batchSizeToBatchNumber,
                            testCase.numberOfRequest,
                            "FilterViewQueryOwnedBy",
                            inputIdentities.stream().map(identityToJsonNode).collect(toImmutableSet())),
                    testCase.opaConfig);
}

The nice thing about this is that when a case fails the traceback will point you the line that failed, so you don't have to figure out which element in the for loop failed

[mosiac1]

nit: we could add a toJsonNode util that takes an object so we don't have to double quote the string

[mosiac1]

From what I've seen in previous PRs, what Praveen is refering to is doing something like

@Test
public void testFilterViewQueryOwnedBy()
{
    ...
    assertFilterViewQueryOwnedBy(new TestCase(OPA_CONFIG_NO_BATCH_SIZE, ImmutableMap.of(11, 1), 1));
    ...
}

void assertFilterViewQueryOwnedBy(TestCase testCase)
{
            assertAccessControlMethodBehaviour(
                    (accessControl, systemSecurityContext, identities) -> accessControl.filterViewQueryOwnedBy(systemSecurityContext.getIdentity(), identities),
                    inputIdentities,
                    identityToJsonNode,
                    new ExpectedRequestProperties(
                            testCase.batchSizeToBatchNumber,
                            testCase.numberOfRequest,
                            "FilterViewQueryOwnedBy",
                            inputIdentities.stream().map(identityToJsonNode).collect(toImmutableSet())),
                    testCase.opaConfig);
}

The nice thing about this is that when a case fails the traceback will point you the line that failed, so you don't have to figure out which element in the for loop failed