Skip to content

Reduce contribution of RLE blocks size in page splitting #25851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

raunaqmorarka
Copy link
Member

Description

Consider only the underlying value block size for RLE blocks in page splitting calculation.
This prevents the splitting up of Pages due to getSizeInBytes of RLE blocks being a factor of positions count

Additional context and related issues

Follow-up of #25256 (comment)

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Consider only the underlying value block size for RLE blocks in
page splitting calculation. This prevents the splitting up of Pages
due to getSizeInBytes of RLE blocks being a factor of positions count
@cla-bot cla-bot bot added the cla-signed label May 22, 2025
@raunaqmorarka raunaqmorarka requested review from dain and pettyjamesm May 22, 2025 09:31
@starburstdata-automation
Copy link

starburstdata-automation commented May 22, 2025

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_part.

Building Trino finished with status: success
Benchmark finished with status: success
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: NO Regression found.
Benchmark Comparison to the closest run from Master: Report

@starburstdata-automation
Copy link

starburstdata-automation commented May 22, 2025

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_unpart.

Building Trino finished with status: success
Benchmark finished with status: success
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: NO Regression found.
Benchmark Comparison to the closest run from Master: Report

@raunaqmorarka
Copy link
Member Author

Screenshot 2025-05-22 at 7 10 57 PM Screenshot 2025-05-22 at 7 08 41 PM

@raunaqmorarka raunaqmorarka merged commit 0470106 into master May 26, 2025
102 checks passed
@raunaqmorarka raunaqmorarka deleted the raunaq/page-split-rle branch May 26, 2025 04:54
@github-actions github-actions bot added this to the 476 milestone May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants