Remove redundant variable in TestDeltaLakeFileBasedTableStatisticsProvider #25853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjian2664
force-pushed
the
nit_simplify
branch
from
95d4363 to
dc9bd3a
Compare
ebyhr
reviewed
May 23, 2025
| @@ -469,8 +469,7 @@ private TableStatistics getTableStatistics(ConnectorSession session, DeltaLakeTa | |||
| catch (IOException e) { | |||
| throw new RuntimeException(e); | |||
| } | |||
| TableStatistics tableStatistics = tableStatisticsProvider.getTableStatistics(session, tableHandle, tableSnapshot); | |||
| return tableStatistics; | |||
| return tableStatisticsProvider.getTableStatistics(session, tableHandle, tableSnapshot); | |||
There was a problem hiding this comment.
A redundant variable is sometimes helpful during debugging.
I'm okay with this change since most callers use a local variable, though.
ebyhr
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: