Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logic to validate multi proof vc\vp #1828

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

skynet2
Copy link
Member

@skynet2 skynet2 commented Dec 30, 2024

VC
According to the spec https://www.w3.org/TR/vc-data-integrity/#proofs, VC can have multiple proofs (Proof Sets), which is currently supported.

Proof Graphs & Chains are more advanced features that are not currently supported by vcs & vc-go.

VP
The spec does not directly mention that the VP should have only 1 Proof because the VP is VC. We will handle it like VC during proof validation.
As we generate options (challenge, domain, etc.) during the OIDC4VP flow, we expect that all proofs will have this option in the presentation.

@cla-bot cla-bot bot added the cla-signed label Dec 30, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.62%. Comparing base (8d5b3bf) to head (6c49a00).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1828   +/-   ##
=======================================
  Coverage   72.62%   72.62%           
=======================================
  Files          33       33           
  Lines        2141     2141           
=======================================
  Hits         1555     1555           
  Misses        532      532           
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fqutishat fqutishat merged commit 56e373a into trustbloc:main Jan 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants