Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

feat: wallet integration for GNAP auth flow (WIP) #1769

Closed
wants to merge 1 commit into from

Conversation

birtony
Copy link
Contributor

@birtony birtony commented Jun 29, 2022

Fixes #1768

@cla-bot cla-bot bot added the cla-signed label Jun 29, 2022
@birtony birtony changed the title feat: wallet integration for GNAP auth flow feat: wallet integration for GNAP auth flow (WIP) Jun 29, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #1769 (ebae793) into main (695c043) will not change coverage.
The diff coverage is n/a.

❗ Current head ebae793 differs from pull request most recent head b9df1dd. Consider uploading reports for the commit b9df1dd to get more accurate results

@@           Coverage Diff           @@
##             main    #1769   +/-   ##
=======================================
  Coverage   87.16%   87.16%           
=======================================
  Files          12       12           
  Lines        1356     1356           
=======================================
  Hits         1182     1182           
  Misses        104      104           
  Partials       70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 695c043...b9df1dd. Read the comment docs.

@birtony birtony force-pushed the pr-1761 branch 2 times, most recently from 96fc2dd to 3f4be02 Compare June 29, 2022 20:17
@birtony birtony added type: enhancement New feature or request area: UI Something related to UI area: integration tests area: docker labels Jun 29, 2022
@birtony
Copy link
Contributor Author

birtony commented Jun 30, 2022

Update - user can successfully authenticate

GNAP-Auth.mov

OIDC Issue

GNAP-OIDC-Issue.mov

OIDC Share

OIDC-Share.mov

@birtony birtony force-pushed the pr-1761 branch 7 times, most recently from 518fd4b to cfc36f6 Compare July 11, 2022 23:56
Signed-off-by: Anton Biriukov <anton.biriukov@avast.com>
@rolsonquadras
Copy link
Member

Changes from this PR were pulled into #1785

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish GNAP flow integration in wallet and auth
5 participants