This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
fix: addressing comments for gnap integration and cleanup #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birtony
added
type: fix
Codecov Report
@@ Coverage Diff @@
## main #1790 +/- ##
=======================================
Coverage 87.16% 87.16%
=======================================
Files 12 12
Lines 1356 1356
=======================================
Hits 1182 1182
Misses 104 104
Partials 70 70 Continue to review full report at Codecov.
|
Signed-off-by: Anton Biriukov <anton.biriukov@avast.com>
birtony
changed the title
birtony
requested review from
rolsonquadras,
talwinder50,
sudeshrshetty and
HeidiHan0000
sudeshrshetty
approved these changes
Jul 15, 2022
rolsonquadras
approved these changes
Jul 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1788
Signed-off-by: Anton Biriukov anton.biriukov@avast.com