Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate mod and move applicable checks into GitHub Insights mod closes #50 #51

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

khushboo9024
Copy link
Contributor

@khushboo9024 khushboo9024 commented Aug 1, 2023

Checklist

  • Issue(s) linked

@khushboo9024 khushboo9024 self-assigned this Aug 1, 2023
@khushboo9024 khushboo9024 requested a review from misraved August 1, 2023 17:00
@khushboo9024 khushboo9024 changed the title Deprecate mod and move applicable checks into GitHub Insights mod clo… Deprecate mod and move applicable checks into GitHub Insights mod closes #50 Aug 1, 2023
Copy link
Contributor

@cbruno10 cbruno10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khushboo9024 Please see suggestions, thanks!

README.md Outdated
@@ -1,3 +1,9 @@
# :warning: DEPRECATED

The GitHub Sherlock Mod has been deprecated and all the existing controls are migrated to GitHub Insight Mod. Please use the [GitHub Insights Mod](https://hub.steampipe.io/mods/turbot/github_insights) instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The GitHub Sherlock Mod has been deprecated and all the existing controls are migrated to GitHub Insight Mod. Please use the [GitHub Insights Mod](https://hub.steampipe.io/mods/turbot/github_insights) instead.
The GitHub Sherlock Mod has been deprecated and all the existing controls have been migrated to the GitHub Insight Mod. Please use the [GitHub Insights Mod](https://hub.steampipe.io/mods/turbot/github_insights) instead.

docs/index.md Outdated
# GitHub Sherlock Mod
# GitHub Sherlock Mod [DEPRECATED]

The GitHub Sherlock Mod has been deprecated and all the existing controls are migrated to GitHub Insight Mod. Please use the [GitHub Insights Mod](https://hub.steampipe.io/mods/turbot/github_insights) instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The GitHub Sherlock Mod has been deprecated and all the existing controls are migrated to GitHub Insight Mod. Please use the [GitHub Insights Mod](https://hub.steampipe.io/mods/turbot/github_insights) instead.
The GitHub Sherlock Mod has been deprecated and all the existing controls have been migrated to GitHub Insight Mod. Please use the [GitHub Insights Mod](https://hub.steampipe.io/mods/turbot/github_insights) instead.

Base automatically changed from release/v0.12 to main February 28, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants