-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support backwards index scan and seeks + utilize indexes in removing ORDER BY #1209
Conversation
dd861d7
to
82c0be9
Compare
@PThorpe92 github wont let me add you as a reviewer for some reason so I'm adding you this way |
51ffa6f
to
190c0ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After very extensive review and local testing sir I can confidently say that this does indeed LGTM 🫡
The fuzz tests ran for so long that I thought it might have caught an infinite loop but it ended up pasing.
Main stuff
Bytecode examples (note the lack of order by sorting):
one column index order by, forwards:
one column index order by, backwards:
rowid seek, backwards:
two column order by, setup:
two column order by, forwards:
two column order by, forwards with index seek:
two column order by, forwards with index scan and termination condition:
two column order by, backwards:
two column order by, backwards with index seek:
two column order by, backwards with index scan and termination condition: