Update offcanvas.md To Mention Adding data-bs-target for Close Buttons in Offcanvas Components #41325
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a note in the Responsive section to indicate that "Close" buttons in responsive offcanvas components must have a data-bs-target attribute to function.
Added a line break for better visual clarity and improved wording
|
I edited and reorganized the content there. Thanks! |
julien-deramond
requested review from
mdo and
julien-deramond
and removed request for
mdo
julien-deramond
approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Thanks for the PR @ASchoe311 and @mdo for the edit 👌
LGTM! It sounds clearer for the users :)
Just added a comment for you Mark related to a typo.
| @@ -163,7 +163,16 @@ Change the appearance of offcanvases with utilities to better match them to diff | |||
|
|
|||
| {{< added-in "5.2.0" >}} | |||
|
|
|||
| Responsive offcanvas classes hide content outside the viewport from a specified breakpoint and down. Above that breakpoint, the contents within will behave as usual. For example, `.offcanvas-lg` hides content in an offcanvas below the `lg` breakpoint, but shows the content above the `lg` breakpoint. | |||
| Responsive offcanvas classes hide content outside the viewport from a specified breakpoint and down. Above that breakpoint, the contents within will behave as usual. For example, `.offcanvas-lg` hides content in an offcanvas below the `lg` breakpoint, but shows the content above the `lg` breakpoint. Responsive offcanvas classes are available across for each breakpoint. | |||
There was a problem hiding this comment.
Suggested change
| Responsive offcanvas classes hide content outside the viewport from a specified breakpoint and down. Above that breakpoint, the contents within will behave as usual. For example, `.offcanvas-lg` hides content in an offcanvas below the `lg` breakpoint, but shows the content above the `lg` breakpoint. Responsive offcanvas classes are available across for each breakpoint. | |
| Responsive offcanvas classes hide content outside the viewport from a specified breakpoint and down. Above that breakpoint, the contents within will behave as usual. For example, `.offcanvas-lg` hides content in an offcanvas below the `lg` breakpoint, but shows the content above the `lg` breakpoint. Responsive offcanvas classes are available for each breakpoint. |
or "across all breakpoints" 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a note in the Responsive section to indicate that "Close" buttons in responsive offcanvas components must have a data-bs-target attribute to function.
Motivation & Context
It is unclear that data-bs-target is required for the close button in responsive offcanvas components. I was only able to realize this by finding an open issue from 2022.
Type of changes
Checklist
npm run lint)Live previews
Related issues
#36962