-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Header in RecordTable on empty state and show groups in Group By views #11416
Show Header in RecordTable on empty state and show groups in Group By views #11416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
The changes update the empty state rendering in the record table to ensure the header (Fields bar) is always visible when the table is empty and to display the grouped view properly when grouping is applied.
- Updated conditional rendering in /packages/twenty-front/src/modules/object-record/record-table/components/RecordTable.tsx to differentiate between default and grouped empty states.
- Ensured that the RecordTableHeader remains rendered during an empty state.
- Incorporated checks for grouped views using RecordTableRecordGroupBodyEffects and RecordTableRecordGroupsBody while managing nested ternary readability.
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
66c8d0d
to
de40d12
Compare
Fixed it. @FelixMalfait |
…ty into update-table-empty-state
This reverts commit 7733749.
@FelixMalfait Let me know if any further changes are needed |
Hey @Harshit-RV thanks! I took over because the header wasn't displayed properly (missing StyledTable wrapper). Also I thought it'd be nice to disable checkboxes in that case. My update isn't perfect because the header isn't sticky, but that would require a refactoring which is not worth it imo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Closes #11298