fix: Don't invoke pager with shell on Windows

[twpayne]

Fixes #4375.
Fixes #4195.

[LeonardoMor]

Found #4195 locked so I could not reply there.

I can test it, but it'd be a few days before I touch Windows again.

Speaking of which, on Windows 11, if you update chezmoi with

winget update chezmoi

You'll get an error saying something about not having the proper permissions on some folder.

If you repeat as Administrator, the upgrade fails again.

I have been able to reproduce this in two Windows 11 computers.

Should I open an issue for this?

[halostatue]

Found #4195 locked so I could not reply there.

I have unlocked that conversation.

Speaking of which, on Windows 11, if you update chezmoi with
…
Should I open an issue for this?

I would check to see if there are issues reported with winget or check with that. As I understand it, chezmoi does not control how winget updates are performed, but merely makes them available when new releases are built.

[twpayne]

Speaking of which, on Windows 11, if you update chezmoi with
…
Should I open an issue for this?

I would check to see if there are issues reported with winget or check with that. As I understand it, chezmoi does not control how winget updates are performed, but merely makes them available when new releases are built.

This is correct. This is a winget issue, not a chezmoi issue.

[LeonardoMor]

Got it. I'd look into that. It's strange that it happens with chezmoi and not other things that I install with winget, say vim, nvim and so on.

I thought chezmoi would have some control over what and how things are copied and so on.

[twpayne]

I thought chezmoi would have some control over what and how things are copied and so on.

Nope, chezmoi is just a dumb statically-linked binary. You can see everything in the winget PR for the last chezmoi release: microsoft/winget-pkgs#241817