Add strict_model_abstract_attrs setting to allow models.Model.objects access
#2830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ddjango/django-stubs into add-process_abstract_models
|
@UnknownPlatypus do you have any ideas on why this happens? :) |
|
For the record: I added |
asottile-sentry
approved these changes
Sep 16, 2025
flaeppe
approved these changes
Sep 16, 2025
Co-authored-by: anthony sottile <103459774+asottile-sentry@users.noreply.github.com>
asottile-sentry
added a commit
to getsentry/sentry-forked-django-stubs
that referenced
this pull request
Sep 17, 2025
…cts` access (typeddjango#2830) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: anthony sottile <103459774+asottile-sentry@users.noreply.github.com>
asottile-sentry
added a commit
to getsentry/sentry-forked-django-stubs
that referenced
this pull request
Sep 17, 2025
* Revert "don't remove objects / DoesNotExist / etc. from model classes (#2)" This reverts commit 44e609b. * Add `strict_model_abstract_attrs` setting to allow `models.Model.objects` access (typeddjango#2830) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: anthony sottile <103459774+asottile-sentry@users.noreply.github.com> --------- Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this setting so we can test
sentryinmypy-primer. To test it, we need to help Sentry's team to use our package, without their custom fork.So, setting
strict_model_abstract_attrs = falseshould do the trick for them.It can be also helpful for other big projects to adopt
django-stubs.CC @flaeppe and @asottile-sentry
Refs hauntsaninja/mypy_primer#202