Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change 春日影 reading from kasukage to haruhikage #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lunaflight
Copy link

Fixes #2.

All instances of 春日影 and Kasukage have been ripgrepped and fixed accordingly in the whole codebase.
This is just a documentation fix so no tests need to be done.

よろしくおねがいします

@weiseng18
Copy link

Can confirm that the canonical reading is Haruhikage, link to official YouTube video below

https://www.youtube.com/watch?v=bBDJE8prgAE&ab_channel=BanGDream%21GirlsBandParty%21Official

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Typo] 「春日影」is Haruhikage
2 participants