Add Golang-CI and refactor integration tests #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that a lot of things in the build process of a u-bmc image has changed the integration tests needed to be modified to account for these changes. They still got a few issues but the general layout should be final now. Signed-off-by: Marvin Drees <marvin.drees@9elements.com>
Signed-off-by: Marvin Drees <marvin.drees@9elements.com>
Signed-off-by: Marvin Drees <marvin.drees@9elements.com>
Replace the shell scripts with a generate.go file that uses templating and go embed to fill in the variables that are needed in config.go This approach is not ideal yet, as we track the generated.go file for golangci purposes. Signed-off-by: Marvin Drees <marvin.drees@9elements.com>
Removed old rm -rf vendor command from test tasks and specified the directories with go sources which should be tested instead of going wildcard. Also update the CircleCI config in order to reflect the new project config logic. Signed-off-by: Marvin Drees <marvin.drees@9elements.com>
Remove unnecessary comments from the yaml files and update golangci to 1.42.1 Additionally remove generated.go as it should not be tracked via git and add a new step to golang-ci to generate this file Signed-off-by: Marvin Drees <marvin.drees@9elements.com>
Signed-off-by: Marvin Drees <marvin.drees@9elements.com>
Signed-off-by: Marvin Drees <marvin.drees@9elements.com>
Signed-off-by: Marvin Drees <marvin.drees@9elements.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to CircleCI I added the golangci-linter via github actions. The integration tests run by CircleCI are disabled for now as I still need to rewrite the uninit scripts that are being run but as the code is still evolving quickly right now this will happen after the big refactor is done. The CI also now uses the new way of generating a config file which removes the need of shell scripts in the repo.