Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(virt): Enhance service setup and restrict root execution for virtualization script #2116

Open
wants to merge 3 commits into
base: testing
Choose a base branch
from
Open

fix(virt): Enhance service setup and restrict root execution for virtualization script #2116

wants to merge 3 commits into from
+6 −1

Conversation

Zeglius
Copy link
Contributor

@Zeglius Zeglius commented Jan 13, 2025

Improve the bazzite-libvirtd-setup.service to restore SELinux context and prevent running the setup-virtualization script as root.

Fixes issue #2115.

@Zeglius Zeglius requested a review from HikariKnight as a code owner January 13, 2025 00:29
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jan 13, 2025
p5
p5 reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@p5 p5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing this PR doesn't appear to do is create the /var/log/libvirt directory. So I think you'd be running restorecon on a non-existant location (unless simply starting the libvirtd service creates it).

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p5 p5 p5 left review comments

@HikariKnight HikariKnight HikariKnight approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeglius @HikariKnight @p5