-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Port SRW to Gaea C6 #1163
[develop] Port SRW to Gaea C6 #1163
Conversation
Passed comprehensive tests:
For runs used UFS-WM branch: https://github.com/BrianCurtis-NOAA/ufs-weather-model.git -b gaeac6 PR#2448 |
@RatkoVasic-NOAA I have discussed the Jenkins labels for Gaea-C5 and Gaea-C6 with Kris Booker. The newly added I'm working in a copy of your branch to remove |
@MichaelLueken that's OK. I'm currently running tests on: Hera, Hercules, Jet, Orion, Gaea-C5, Gaea-C6, and Derecho. Some are already done. I'll retest gaea-c5 after your changes. |
@RatkoVasic-NOAA The majority of the modifications have been made and the both the automated build script ( |
Hera:
Jet:
Gaea-c6:
Orion:
Hercules:
Derecho:
|
@RatkoVasic-NOAA PR #15 was created in your fork. Once merged, this PR will be ready for review. |
[gaea-c6] Replace gaea-c5 with gaea to allow Jenkins automated testing to pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm building the SRW App on Gaea-C6 using the Jenkins scripts. Once built, I will run the fundamental WE2E tests using the Jenkins scripts as well. I'll run the Jenkins task test script after the fundamental tests successfully finish. I should be able to approve the changes once those tests are complete.
I noted one minor issue with the doc/UsersGuide/CustomizingTheWorkflow/ConfigWorkflow.rst
file. There is still mention of GAEA-C5
and GAEA-C6
, rather than GAEA
and GAEA-C6
. Please remove the -C5
from GAEA-C5
on line 33 of the rst file.
The Jenkins
Submitting the |
The
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the change, @RatkoVasic-NOAA! Everything looks great and the Jenkins scripts are working correctly on Gaea-C6. I will now approve this PR.
I was also able to successfully run the UFS-Fire WE2E tests on Gaea-C6:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ran fundamental test on Gaea c6 and it passed:
Experienced strange behaviors were the devbuild script didn't build the |
Jenkins is not yet running on Gaea-C6, so I will manually run the coverage tests on that machine. Additionally, Hera epic space has exceeded disk quota, so will manually run in stmp space. |
The coverage tests have successfully passed on Gaea-C6:
|
The Hera Intel coverage WE2E tests have successfully passed:
|
@RatkoVasic-NOAA @MichaelLueken , I am trying to run the sample configuration
The
Do you have any idea what is wrong? I am using |
@RatkoVasic-NOAA @MichaelLueken , I found out I should have run it in
What do you think about this? |
@chan-hoo, the settings in the
using the settings currently in |
The Jenkins tests completed. The tests on Derecho, Hercules, Jet, and Orion successfully passed. The Jenkins runner lost communication with Gaea during the
The Hera GNU WE2E coverage tests have also successfully passed:
With this, all WE2E coverage tests have successfully passed. Once discussions on the |
@MichaelLueken ,
However, they are duplicated in the
|
@chan-hoo, there is nothing currently in the SRW App's standards that require the use of Please feel free to request a change to have @RatkoVasic-NOAA update the |
Discussing this during the daily scrum this morning, @chan-hoo and I have agreed to move forward with merging this work to develop at this time. I have opened issue #1176, so that I can make changes to both Gaea C5 and Gaea C6 machine files so that they follow the same standard as the rest of the machine files. |
DESCRIPTION OF CHANGES:
Enable SRW for new machine Gaea-C6
NOTE1: needs to update SRW to new UFS-WM version (after PR2448)
NOTE2: on Gaea C6 for tests use account bil-fire8, not epic, i.e. ./run_WE2E_tests.py -t fundamental -m gaea-c6 -a bil-fire8
UFS_SRW_data copied to /gpfs/f6/bil-fire8/world-shared/UFS_SRW_data location.
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
DOCUMENTATION:
rst files updated.
ISSUE:
Closes issue #1120
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR: