AWS Paas Migration Changes #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -44,6 +44,7 @@ | |||
| "clean": "rm -f ./run/static/webpack_bundles/*", | |||
| "heroku-prebuild": "", | |||
| "heroku-postbuild": "npm run build", | |||
| "start": "echo starting", | |||
There was a problem hiding this comment.
Is start a placeholder for a future script? (We've tended not to introduce placeholders into production code.)
There was a problem hiding this comment.
Again this is a work-around for node.js buildpack
There was a problem hiding this comment.
Agreed with @emileswarts to replace "echo starting" with something that documents the dummy "start" script entry - e.g. "start": "dummy entry for node.js buildpack workaround".
There was a problem hiding this comment.
Pointing this at bash web-worker-entrypoint.sh will be sufficient for this workaround, but means that we can't add the comment to indicate that it's a workaround.
PaulWheatcroft
force-pushed
the
paas-migration
branch
from
7f0a9ae to
07586b2
Compare
emileswarts
force-pushed
the
paas-migration
branch
from
07586b2 to
19f1376
Compare
emileswarts
force-pushed
the
paas-migration
branch
3 times, most recently
from
d30c74f to
805ca50
Compare
emileswarts
force-pushed
the
paas-migration
branch
from
805ca50 to
ed2ffaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to enable AWS migration
Why
To facilitate the application(s) in the repo to be deployed on to the new AWS platform