TP2000-1765-Fix-measures-search-conditions-bug #1428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TP2000-1765-Fix-measures-search-conditions-bug
Why
HMRC have reported a bug when searching for measures gives a 500 response. This is because the conditions macro looks for the latest transaction in the workbasket to determine the conditions to show and HMRC users do not have a workbasket.
What
This PR updates the conditions macro to only check for the latest transaction if a workbasket is present. If not it will set the latest transaction to None which makes the
approved_up_to_transactiondefault to the latest approved.