Fix conversion of floats (#90)

* Fix conversion of floats Just converting the value to int will truncate, when float conversion may have rounded already. * Update CI Python versions
unified-font-object · Jul 30, 2024 · cff786e · cff786e
1 parent 2d4c06c
commit cff786e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -17,7 +17,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ['3.6', '3.7', '3.8', '3.9']
+        python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']
 
     steps:
     - name: Log reason (manual run only)

diff --git a/src/ufonormalizer/__init__.py b/src/ufonormalizer/__init__.py
@@ -1417,7 +1417,7 @@ def xmlConvertFloat(value):
     if "." in string:
         string = string.rstrip("0")
         if string[-1] == ".":
-            return xmlConvertInt(int(value))
+            return xmlConvertInt(int(string[:-1]))
     return string
 
 

diff --git a/tests/test_ufonormalizer.py b/tests/test_ufonormalizer.py
@@ -1813,6 +1813,7 @@ def test_xmlConvertFloat(self):
         self.assertEqual(xmlConvertFloat(1.0000000001), '1.0000000001')
         self.assertEqual(xmlConvertFloat(1.00000000001), '1')
         self.assertEqual(xmlConvertFloat(1.00000000009), '1.0000000001')
+        self.assertEqual(xmlConvertFloat(0.9999999999999999), '1')
 
     def test_xmlConvertFloat_no_rounding(self):
         import ufonormalizer