docs/contribution: added link to docker installation for MacOS. #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current documentation doesn't provide details on how to install unikraft within macos. With the new update, it requires installing docker through .dmg file from the official docker website, the updated documentation will allow users to be able to install docker for MacOS without running into errors. Signed-off-by : Ayan Das dasa60196@gmail.com
StefanJum
requested changes
Feb 23, 2025
There was a problem hiding this comment.
@DeveloperMindset123 please remove the search-meta.json and package-lock.json files from the commit, and see the inline comment.
Also wrap the commit description at 70-80 characters per line.
| @@ -60,6 +60,8 @@ You can do that by following the instructions [here](https://github.com/docker/d | |||
| ```console | |||
| curl -fsSL https://get.docker.com/ | sh | |||
| ``` | |||
| ### Important Note | |||
There was a problem hiding this comment.
Suggested change
| ### Important Note | |
| ### Important Note | |
Add blank linkes here
nderjung
requested changes
Feb 24, 2025
| @@ -60,6 +60,8 @@ You can do that by following the instructions [here](https://github.com/docker/d | |||
| ```console | |||
| curl -fsSL https://get.docker.com/ | sh | |||
| ``` | |||
| ### Important Note | |||
| If you happen to be using `MacOS`, please refer to the following documentation [here](https://docs.docker.com/desktop/setup/install/mac-install/) instead. | |||
There was a problem hiding this comment.
Please remove quotes around macOS:
- `MacOS`
+ macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current documentation doesn't provide details on how to install unikraft within macos. With the new update, it requires installing docker through .dmg file from the official docker website, the updated documentation will allow users to be able to install docker for MacOS without running into errors.
Signed-off-by : Ayan Das dasa60196@gmail.com