Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use native stripVTControlCharacters #378

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kricsleo
Copy link
Member

resolves #377

This PR:

  • Migrates stripAnsi to Node.js native stripVTControlCharacters

  • Removes the exported stripAnsi since it contains no additional logic.
    Users should use stripVTControlCharacters directly.
    (Or do you suggest keeping it exported to minimize breaking changes? 🤔)

  • Bumps the engines to "node": ">=16.11.0"

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 28.55%. Comparing base (24c98ce) to head (7708d84).
Report is 57 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/box.ts 14.28% 6 Missing ⚠️
src/reporters/fancy.ts 50.00% 1 Missing ⚠️
src/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #378       +/-   ##
===========================================
- Coverage   61.08%   28.55%   -32.54%     
===========================================
  Files          13       43       +30     
  Lines        1380     1716      +336     
  Branches       58       90       +32     
===========================================
- Hits          843      490      -353     
- Misses        537     1197      +660     
- Partials        0       29       +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use native stripVTControlCharacters
1 participant