Skip to content

Fix skin-canvas visibility #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

catfromplan9
Copy link
Contributor

skin-canvas is being hidden due to being part of noscript-hidden class. Added JS to remove skin-canvas from noscript-hidden class, because if SkinURL is set the skin-canvas will be drawn. When JS is disabled, this will not be executed and the canvas will remain hidden.

skin-canvas is being hidden due to being part of noscript-hidden class.
Added JS to remove skin-canvas from noscript-hidden class, because if
SkinURL is set the skin-canvas will be drawn. When JS is disabled,
this will not be executed and the canvas will remain hidden.
@evan-goode
Copy link
Member

This is already done in a script in layout.tmpl?

@catfromplan9
Copy link
Contributor Author

This is already done in a script in layout.tmpl?

Doesn't seem to be working for me

@evan-goode
Copy link
Member

Can you reproduce it on a fresh install (the OCI container might be useful)? Here is where it's done:

for (const el of document.querySelectorAll(".noscript-hidden")) {

@catfromplan9
Copy link
Contributor Author

Can you reproduce it on a fresh install (the OCI container might be useful)? Here is where it's done:

for (const el of document.querySelectorAll(".noscript-hidden")) {

The problem is that this relies upon .App.Config.EnableBackgroundEffect being set to true, you've put it into the same if statement as that

@catfromplan9
Copy link
Contributor Author

Oh, I guess the version I am running predates this commit: 03ee17c

@catfromplan9
Copy link
Contributor Author

I am running the tagged 3.0.0 release, which was tagged a week before that commit fixed it. I'm waiting for a new tagged release to fix it.

@evan-goode
Copy link
Member

I realize I didn't push the v3.1.0 tag, so I just pushed v3.1.1.

@evan-goode evan-goode closed this Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants