Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Disable CoreWindow in single-window targets #19800

Merged
merged 3 commits into from
Apr 7, 2025
Merged

fix: Disable CoreWindow in single-window targets #19800

merged 3 commits into from
Apr 7, 2025
+3 −4

Conversation

MartinZikmund
Copy link
Member

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19800/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19800/index.html

@MartinZikmund MartinZikmund force-pushed the dev/mazi/singlewindow-skia branch 2 times, most recently from ffb0d11 to 126266b Compare April 2, 2025 07:17
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19800/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19800/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 159426 has failed on Uno.UI - CI.

@MartinZikmund MartinZikmund self-assigned this Apr 3, 2025
@MartinZikmund MartinZikmund force-pushed the dev/mazi/singlewindow-skia branch from 8613e32 to 1cf693d Compare April 3, 2025 14:40
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19800/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19800/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 159663 has failed on Uno.UI - CI.

@MartinZikmund MartinZikmund force-pushed the dev/mazi/singlewindow-skia branch from 1cf693d to 4a7a28c Compare April 4, 2025 13:04
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19800/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19800/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 159836 has failed on Uno.UI - CI.

@MartinZikmund MartinZikmund force-pushed the dev/mazi/singlewindow-skia branch from 4a7a28c to 4b2c440 Compare April 7, 2025 08:09
@MartinZikmund
fix: Disable CoreWindow in single-window targets
6ee5540
@MartinZikmund
fix(VisualTree): Correctly load XamlIslandRoot
e79a84d 
Replaced the conditional check for `root.XamlRoot?.VisualTree.RootElement` with a direct check for `RootElement` in `VisualTree.cs`. This change removes the dependency on `XamlRoot`, streamlining the logic while ensuring that `xamlIsland` is still marked as loaded if it exists.
@MartinZikmund
chore: Override window type
31b50cb
@MartinZikmund MartinZikmund force-pushed the dev/mazi/singlewindow-skia branch from 4b2c440 to 31b50cb Compare April 7, 2025 08:10
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19800/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19800/index.html

@jeromelaban jeromelaban merged commit 1d147bc into master Apr 7, 2025
68 of 71 checks passed
@jeromelaban jeromelaban deleted the dev/mazi/singlewindow-skia branch April 7, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees

@MartinZikmund MartinZikmund

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinZikmund @unodevops @jeromelaban