refactor(cardano): align PParms field names with db-sync naming conventions #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the field names of the protocol parameters to align with the naming conventions used in db-sync.
Most of these changes are straightforward. However, one notable example is the
max_execution_units_per_transaction
parameter. In the current spec, this parameter is defined as:ExUnits max_execution_units_per_transaction
where
ExUnits
is defined as:In db-sync, there isn’t a single field corresponding to
max_execution_units_per_transaction
. Instead, db-sync uses separate fields:max_tx_ex_steps
andmax_tx_ex_mem
. To address this, we’ve chosen to renamemax_execution_units_per_transaction
tomax_tx_ex
while retaining the ExUnits type and just chaning the name frommemory
tomem
. This approach kind of matches the naming convention in db-sync without significantly altering the spec.An alternative would be to remove the ExUnits type entirely and define
max_tx_ex_steps
andmax_tx_ex_mem
as separate fields. However, this would be a more substantial change to the structure.This also applies to the following parameters:
max_execution_units_per_block
prices