Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for copy_without_assign Coverity hits. #3119

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

KateBlueSky
Copy link
Contributor

@KateBlueSky KateBlueSky commented Mar 14, 2025

Description

Fixed the COPY_WITHOUT_ASSIGN Coverity hits


Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@KateBlueSky
Copy link
Contributor Author

/intelci: run

1 similar comment
@KateBlueSky
Copy link
Contributor Author

/intelci: run

@KateBlueSky KateBlueSky marked this pull request as ready for review March 14, 2025 23:09
@KateBlueSky
Copy link
Contributor Author

/intelci: run

Copy link
Contributor

@icfaust icfaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly very dumb question, I have a similar copy assignment operator coverity hit in #3122 . How come you do the check for self assign? Is that just to speed up in that circumstance, and should we be doing this with the other copy assignment operators in DAAL? Otherwise a very straightforward PR.

@Vika-F
Copy link
Contributor

Vika-F commented Mar 20, 2025

Possibly very dumb question, I have a similar copy assignment operator coverity hit in #3122 . How come you do the check for self assign? Is that just to speed up in that circumstance, and should we be doing this with the other copy assignment operators in DAAL? Otherwise a very straightforward PR.

@KateBlueSky @icfaust
From my understanding, it is not necessary to do the actual implementation as compiler can handle that for us.
It would be enough just to add = default; implementation here and in the other respective places like it is done for other algorithms:
https://github.com/uxlfoundation/oneDAL/blob/main/cpp/daal/src/algorithms/kernel_function/kernel_function.cpp#L47

@@ -106,6 +106,16 @@ class DAAL_EXPORT Input : public daal::algorithms::Input
Input();
Input(const Input & other);

Input & operator=(const Input & other)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that these are public headers. Better to move the implementation to a .cpp file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants