-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for copy_without_assign Coverity hits. #3119
base: main
Are you sure you want to change the base?
Conversation
/intelci: run |
1 similar comment
/intelci: run |
/intelci: run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly very dumb question, I have a similar copy assignment operator coverity hit in #3122 . How come you do the check for self assign? Is that just to speed up in that circumstance, and should we be doing this with the other copy assignment operators in DAAL? Otherwise a very straightforward PR.
@KateBlueSky @icfaust |
@@ -106,6 +106,16 @@ class DAAL_EXPORT Input : public daal::algorithms::Input | |||
Input(); | |||
Input(const Input & other); | |||
|
|||
Input & operator=(const Input & other) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that these are public headers. Better to move the implementation to a .cpp file.
Description
Fixed the COPY_WITHOUT_ASSIGN Coverity hits
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance