Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correlation distance algorithm #3131

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

richardnorth3
Copy link
Contributor

@richardnorth3 richardnorth3 commented Mar 19, 2025

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Signed-off-by: North Iii <richard.north.iii@intel.com>
@icfaust icfaust marked this pull request as draft March 19, 2025 15:21
@icfaust
Copy link
Contributor

icfaust commented Mar 19, 2025

Hey @richardnorth3 sorry if I overstepped, I marked it as still draft. Make sure to strip out the rbf_kernel from the gpu backend, I assume you'll use the correlation distance primitive for GPU, and make sure to write a fleshed-out description.

Its looking good!

@richardnorth3
Copy link
Contributor Author

Hey @richardnorth3 sorry if I overstepped, I marked it as still draft. Make sure to strip out the rbf_kernel from the gpu backend, I assume you'll use the correlation distance primitive for GPU, and make sure to write a fleshed-out description.

Its looking good!

No, thank you for putting the PR back into draft mode! I accidentally pushed it as a PR and just wanted to merge what changes I had locally in case I lost them. Think the algorithm is mostly finished now and I just have to finish the testing portion.

@richardnorth3 richardnorth3 added dpc++ Issue/PR related to DPC++ functionality new algorithm New algorithm or method in oneDAL oneAPI Issue/PR related to oneAPI part labels Mar 19, 2025
richard.north.iii and others added 4 commits March 19, 2025 16:01
Signed-off-by: richard.north.iii <rnorthii@smtp.jf.intel.com>
Signed-off-by: North Iii <richard.north.iii@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dpc++ Issue/PR related to DPC++ functionality new algorithm New algorithm or method in oneDAL oneAPI Issue/PR related to oneAPI part
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants