cpu: aarch64: softmax: fix segv, improve performance, enable blk_size = 4 #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzarukin
reviewed
Mar 1, 2024
| @@ -46,6 +46,7 @@ const std::map<pk_impl_key_t, std::vector<impl_list_item_t>> &impl_list_map() { | |||
| CPU_INSTANCE_X64(jit_uni_softmax_fwd_t) | |||
| CPU_INSTANCE_AARCH64(jit_uni_softmax_fwd_t<sve_512>) | |||
| CPU_INSTANCE_AARCH64(jit_uni_softmax_fwd_t<sve_256>) | |||
| CPU_INSTANCE_AARCH64(jit_uni_softmax_fwd_t<sve_128>) | |||
There was a problem hiding this comment.
Minor: please consider removing templated argument for softmax implementation as with time it becomes bulky.
There was a problem hiding this comment.
Thank you for the comment. I'd like to improve templated argument in future PR.
kawakami-k
force-pushed
the
20240301_softmax
branch
from
fa066ac to
33f6c55
Compare
mgouicem
approved these changes
Mar 7, 2024
vpirogov
added
the
platform:cpu-aarch64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the following three improvement for Softmax on AArch64.
SIGSEGV can be reproduce by the following command on AArch64 SVE 512 environment with 51a92cc
stag=aBx4bis added totests/benchdnn/inputs/softmax/test_softmax_allfor testing blk_size =4 cases.Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?Bug fixes