rfc: proposal for block level APIs #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaraujom
reviewed
Apr 1, 2024
jgong5
reviewed
Apr 4, 2024
| change the API when we introduce the feature, or add a placeholder | ||
| parameter if we are confident this feature will gain traction soon. | ||
|
|
||
| Also, note that currently, no kernel-level cache exists for block |
There was a problem hiding this comment.
The caching support is a must for performance. Frameworks have to provide their own cache support if oneDNN doesn't support it. oneDNN supports it at the beginning would be ideal.
jgong5
reviewed
Apr 4, 2024
ZhennanQin
reviewed
Apr 7, 2024
ZhennanQin
reviewed
Apr 7, 2024
ZhennanQin
reviewed
Apr 7, 2024
|
|
||
| ## Handling of attributes | ||
|
|
||
| First, here is the list of attributes we plan on exposing: |
There was a problem hiding this comment.
I suggest adding ISA and accumulation_datatype as attributes as well for end-user to control.
ZhennanQin
reviewed
Apr 7, 2024
nivas-x86
reviewed
Apr 8, 2024
nivas-x86
reviewed
Apr 9, 2024
CaoE
reviewed
Apr 25, 2024
CaoE
reviewed
Apr 25, 2024
CaoE
reviewed
Apr 25, 2024
mgouicem
force-pushed
the
mgouicem/rfcs/brgemm
branch
from
03a286e to
da0e72f
Compare
mgouicem
force-pushed
the
mgouicem/rfcs/brgemm
branch
from
da0e72f to
2de75d1
Compare
dzarukin
approved these changes
Mar 12, 2025
vpirogov
approved these changes
Mar 12, 2025
|
Merge as functionality is available in the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to expose block level API on CPU, namely brgemm and transforms.
Rendered version