Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpu: sycl: binary: add support for remaining post ops #1880

Merged
merged 1 commit into from
May 13, 2024

Conversation

t4c1
Copy link
Contributor

@t4c1 t4c1 commented Apr 26, 2024

Add support for the post ops on binary primitive that were previously unsupported (binary, prelu, remaining eltwise ones).

Also fixes a bug in three-way type equality comparison that prevented binary running with bf16 type.

@t4c1 t4c1 force-pushed the binary_post_ops branch from 2520dea to 654e06b Compare April 26, 2024 11:00
@dzarukin
Copy link
Contributor

dzarukin commented May 1, 2024

Please resolve conflicts.

@t4c1 t4c1 force-pushed the binary_post_ops branch from 654e06b to 746591f Compare May 6, 2024 14:12
@t4c1
Copy link
Contributor Author

t4c1 commented May 6, 2024

Resolved.

@sgeor255 sgeor255 requested review from densamoilov and igorsafo May 8, 2024 15:37
@t4c1 t4c1 force-pushed the binary_post_ops branch 2 times, most recently from fab4b27 to bb307f0 Compare May 9, 2024 11:28
@t4c1 t4c1 force-pushed the binary_post_ops branch from bb307f0 to 170bfaf Compare May 9, 2024 13:45
@mgouicem mgouicem merged commit f7bbf4b into uxlfoundation:main May 13, 2024
10 checks passed
@vpirogov vpirogov added platform:gpu-nvidia Codeowner: @oneapi-src/onednn-gpu-nvidia platform:gpu-amd Codeowner: @oneapi-src/onednn-gpu-amd labels May 21, 2024
@vpirogov vpirogov added this to the v3.6 milestone May 21, 2024
@vpirogov vpirogov added platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic and removed platform:gpu-nvidia Codeowner: @oneapi-src/onednn-gpu-nvidia platform:gpu-amd Codeowner: @oneapi-src/onednn-gpu-amd labels Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants