cpu: aarch64: improve memory management safety for aarch64 kernels #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpirogov
added
the
platform:cpu-aarch64
…8s8s32x_deconvolution.hpp on-behalf-of: @permanence-ai <github-ai@permanence.ai>
…l.hpp on-behalf-of: @permanence-ai <github-ai@permanence.ai>
…rnel_f32.hpp on-behalf-of: @permanence-ai <github-ai@permanence.ai>
…rnel_utils.hpp on-behalf-of: @permanence-ai <github-ai@permanence.ai>
Permanence-AI-Coder
force-pushed
the
new-delete-aarch64
branch
from
2dee5b8 to
88d6237
Compare
theComputeKid
approved these changes
Aug 29, 2024
theComputeKid
requested changes
Aug 29, 2024
theComputeKid
approved these changes
Aug 29, 2024
|
@vpirogov I don't know what is wrong with the bot, I approved the changes but it still shows as |
|
@theComputeKid, nothing is wrong with the bot. The repo is configured to require 2 approvals for any PR per OpenSSF recommendation. |
theComputeKid
pushed a commit
to theComputeKid/oneDNN
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code changes in this PR were generated automatically by the Permanence AI Coder and reviewed by @fwph & @jweese. This PR updates memory allocation across several objects in the aarch64 implementation. Note that the bot is configured to add the
DNNL_DISALLOW_COPY_AND_ASSIGNwhere it is missing; while this is redundant with the use of unique_ptr, it provides more consistency with existing code.on-behalf-of: @permanence-ai github-ai@permanence.ai
General
make testandmake test_benchdnn_*) pass locally for each commit?*172 - test_benchdnn_modeC_brgemm_ci_cpu (Subprocess aborted)is failing both on this branch AND on the main branch.