Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic: sycl: pooling: bug fixes when running on Intel GPU #2039

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

kala855
Copy link
Contributor

@kala855 kala855 commented Aug 15, 2024

Description

There were some cases causing issues like the following when running on Intel PVC devices:

[3214][SRC][1:2:0:3] exp_f32:          64 exp:          64 got:          76 diff:      12 rdiff:  0.1875
[COMPARE_STATS][SRC]: trh=0.078125 err_max_diff:      12 err_max_rdiff:  0.1875 all_max_diff:      28 all_max_rdiff:  0.1875
3627:FAILED (errors:1 total:5746) __REPRO: --pool --engine=gpu --dir=BWD_D --dt=bf16:bf16 ic17ih13oh37kh17ph20

And also some unimplemented ones that were not caught in the implementation:

create: --pool --engine=gpu --tag=aBx16b ic64iw32ow16kw3sw2pw0
Error: Function 'check_dnnl_status' at (/home/svet/oneDNN-intel/tests/benchdnn/dnnl_common.hpp:324) returned 'unimplemented'
Error: Function 'create_primitive' at (/home/svet/oneDNN-intel/tests/benchdnn/dnnl_common.hpp:398) returned '1'
Error: Function 'init_prim' at (/home/svet/oneDNN-intel/tests/benchdnn/dnnl_common.hpp:465) returned '1'
Error: Function 'createit' at (/home/svet/oneDNN-intel/tests/benchdnn/pool/pool.cpp:324) returned '1'
Error: Function 'create' at (/home/svet/oneDNN-intel/tests/benchdnn/utils/task.hpp:49) returned '1'
run: --pool --engine=gpu --tag=aBx16b ic64iw32ow16kw3sw2pw0
3:UNIMPLEMENTED __REPRO: --pool --engine=gpu --tag=aBx16b ic64iw32ow16kw3sw2pw0
create: --pool --engine=gpu --tag=aBx16b --alg=avg_np ic64iw32ow16kw3sw2pw0
Error: Function 'check_dnnl_status' at (/home/svet/oneDNN-intel/tests/benchdnn/dnnl_common.hpp:324) returned 'unimplemented'
Error: Function 'create_primitive' at (/home/svet/oneDNN-intel/tests/benchdnn/dnnl_common.hpp:398) returned '1'
Error: Function 'init_prim' at (/home/svet/oneDNN-intel/tests/benchdnn/dnnl_common.hpp:465) returned '1'
Error: Function 'createit' at (/home/svet/oneDNN-intel/tests/benchdnn/pool/pool.cpp:324) returned '1'
Error: Function 'create' at (/home/svet/oneDNN-intel/tests/benchdnn/utils/task.hpp:49) returned '1'
run: --pool --engine=gpu --tag=aBx16b --alg=avg_np ic64iw32ow16kw3sw2pw0
4:UNIMPLEMENTED __REPRO: --pool --engine=gpu --tag=aBx16b --alg=avg_np ic64iw32ow16kw3sw2pw0

This PR solves the previous bugs.

@kala855 kala855 requested a review from a team as a code owner August 15, 2024 08:39
@kala855 kala855 requested a review from a team August 15, 2024 08:40
@kala855 kala855 force-pushed the kala855/intel-pool-fixes branch from 47f4064 to 9ffdcf1 Compare August 16, 2024 09:49
@kala855 kala855 requested a review from dzarukin August 16, 2024 12:40
@vpirogov vpirogov added the platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic label Aug 16, 2024
@vpirogov vpirogov added this to the v3.6 milestone Aug 16, 2024
@kala855 kala855 force-pushed the kala855/intel-pool-fixes branch 2 times, most recently from f3b7e36 to f7fae04 Compare August 19, 2024 14:15
@kala855 kala855 force-pushed the kala855/intel-pool-fixes branch from f7fae04 to cf28cc9 Compare August 21, 2024 09:19
@kala855 kala855 force-pushed the kala855/intel-pool-fixes branch from cf28cc9 to c67f97e Compare August 29, 2024 20:59
@kala855 kala855 requested a review from dzarukin August 29, 2024 21:08
@vpirogov vpirogov merged commit a708899 into main Sep 7, 2024
13 checks passed
@vpirogov vpirogov deleted the kala855/intel-pool-fixes branch September 7, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants