Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu: aarch64: Enable stateless ACL depthwise convolution #2059

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

theComputeKid
Copy link
Contributor

Checklist

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

- All common conv code is now stateless, so we can delete all legacy code.
- Coindentally fixes uxlfoundation#2033 by making the weights constant
@theComputeKid theComputeKid requested a review from a team as a code owner August 27, 2024 14:45
Copy link
Contributor

@cfRod cfRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internally reviewed

@github-actions github-actions bot added the platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 label Aug 27, 2024
@vpirogov vpirogov added this to the v3.6 milestone Aug 27, 2024
@theComputeKid
Copy link
Contributor Author

@vpirogov good to merge pls!

@vpirogov vpirogov merged commit 16d6dd4 into uxlfoundation:main Aug 27, 2024
12 checks passed
@theComputeKid theComputeKid deleted the depthwise branch September 23, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ACL] non-constant depthwise convolution weights leads to performance degradation
3 participants