Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic: sycl: refactor how post op arguments are loaded #2063

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

t4c1
Copy link
Contributor

@t4c1 t4c1 commented Aug 29, 2024

Refactor where data for post ops is loaded. Instead of the kernel that supports post ops now post ops load any data they need. This has two benefits:

  • data is only loaded if actually used by post ops
  • code is simplified.

@t4c1 t4c1 requested a review from a team as a code owner August 29, 2024 13:42
@github-actions github-actions bot added the platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic label Aug 29, 2024
Copy link
Contributor

@mgouicem mgouicem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dzarukin dzarukin merged commit d05ab57 into uxlfoundation:main Sep 3, 2024
12 checks passed
@vpirogov vpirogov added this to the v3.6 milestone Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants