cpu: aarch64: Fix Threadpool not initializing issue causing test to fail. #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test cpu-tutorials-matmul-matmul-quantization-cpp is failing due to Threadpool not being initialised. This patch fixes the issue by executing the task on a single thread when Threadpool is unavailable. Change-Id: Id20f445ac82a66b696082491507e4e16ac142850 Signed-off-by: Renato Arantes <renato.arantes@arm.com>
renato-arantes
changed the title
theComputeKid
approved these changes
Aug 30, 2024
github-actions
bot
added
the
platform:cpu-aarch64
dzarukin
approved these changes
Aug 30, 2024
theComputeKid
pushed a commit
to theComputeKid/oneDNN
that referenced
this pull request
Sep 16, 2024
…ail (uxlfoundation#2066) Signed-off-by: Renato Arantes <renato.arantes@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test cpu-tutorials-matmul-matmul-quantization-cpp is failing due to Threadpool not being initialised. This patch fixes the issue by executing the task on a single thread when Threadpool is unavailable. It is a response to the comment made by @mgouicem here.
The error can be reproduced executing:
DNNL_VERBOSE=1 ./examples/cpu-tutorials-matmul-matmul-quantization-cppGeneral
make testandmake test_benchdnn_*) pass locally for each commit?Bug fixes