Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpu: generic: sycl: reorder: sum post-ops issues #2096

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

kala855
Copy link
Contributor

@kala855 kala855 commented Sep 18, 2024

Description

Some benchdnn cases were failing.

onednn_verbose,v1,primitive,exec,cpu,reorder,jit_direct_copy:uni,undef,src:f32::blocked:abcd::f0 dst:f32::blocked:abcd::f0,,,2x16x3x4,0.158936
onednn_verbose,v1,primitive,exec,cpu,reorder,jit_direct_copy:uni,undef,src:f32::blocked:abcd::f0 dst:f32::blocked:abcd::f0,,,2x16x3x4,0.166992
onednn_verbose,v1,primitive,exec,gpu,reorder,dpcpp:ref:any,undef,src:f32::blocked:abcd::f0 dst:f32::blocked:abcd::f0,attr-scales:src0:2:f32 attr-post-ops:sum:0.5,,2x16x3x4,0.233887
onednn_verbose,v1,primitive,exec,cpu,reorder,jit_direct_copy:uni,undef,src:f32::blocked:abcd::f0 dst:f32::blocked:abcd::f0,,,2x16x3x4,0.216064
[   0][DST][0:0:0:0] exp_f32: 1.25829e+07 exp: 1.25829e+07 got:         nan diff:     nan rdiff:     nan
[   1][DST][0:0:0:1] exp_f32:-1.25829e+07 exp:-1.25829e+07 got:         nan diff:     nan rdiff:     nan
[   2][DST][0:0:0:2] exp_f32:           0 exp:           0 got:         nan diff:     nan rdiff:     nan
[   3][DST][0:0:0:3] exp_f32:      0.1875 exp:      0.1875 got:         nan diff:     nan rdiff:     nan
[   4][DST][0:0:1:0] exp_f32:       0.375 exp:       0.375 got:         nan diff:     nan rdiff:     nan
[   5][DST][0:0:1:1] exp_f32:        0.75 exp:        0.75 got:         nan diff:     nan rdiff:     nan
[   6][DST][0:0:1:2] exp_f32:       1.125 exp:       1.125 got:         nan diff:     nan rdiff:     nan
[   7][DST][0:0:1:3] exp_f32:         1.5 exp:         1.5 got:         nan diff:     nan rdiff:     nan
[   8][DST][0:0:2:0] exp_f32:          12 exp:          12 got:         nan diff:     nan rdiff:     nan
[   9][DST][0:0:2:1] exp_f32:          48 exp:          48 got:         nan diff:     nan rdiff:     nan
[COMPARE_STATS][DST]: trh=0 err_max_diff:     nan err_max_rdiff:     nan all_max_diff:     nan all_max_rdiff:     nan
1555:FAILED (errors:384 total:384) __REPRO: --reorder --engine=gpu --allow-enum-tags-only=false --sdt=f32 --ddt=f32 --stag=abx --dtag=abx --attr-scales=src:per_dim_1 --attr-post-ops=sum:0.5 2x16x3x4

The issue was because the destination datatype was not correctly set. This PR fixes the problem.

@kala855 kala855 requested a review from a team as a code owner September 18, 2024 09:37
@github-actions github-actions bot added the platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic label Sep 18, 2024
@kala855 kala855 requested a review from a team September 18, 2024 09:42
@densamoilov densamoilov merged commit 8384bba into main Sep 19, 2024
11 of 12 checks passed
@densamoilov densamoilov deleted the kala855/reorder-fix branch September 19, 2024 00:35
@vpirogov vpirogov added this to the v3.7 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants