github: workflows: Add macos smoke tests #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm.. Not ready for review yet. I need to clean the job name string for every matrix combo. |
It would be great to move out as much logic as possible from actions to build.sh/test.sh scripts like it's done for Azure CI. This would help with with debugging and reusability of the code. Also with the job names. |
Signed-off-by: Hamza Butt <hamza.butt@arm.com>
|
@vpirogov I fixed the names at least, now we can see clean names: I 100% agree with your sentiment, I was waiting to have at least 2 OS's to make sure I have a cross platform build script, so that I only need to write it once. I'll bring forward my plans and do it as part of this change then. |
vpirogov
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding smoke tests for macos-14, for clang.
Unfortunately, we have test failures (per config) and warnings (per compiler), so we cannot turn on Werror and we also need to attach test failures to specific configurations.
We want to remove all test failures and warnings. This is a work in progress to at least remove some warnings (#2116). If we can get ci in as fast as possible for at least one OS, even in a primitive, messy state, we can stop more test failures and warnings from being added.
I also applied formatting to the YAML file.
There are some problems with GCC testing that needs some investigation from myself but I didn't want GCC to stop me from starting testing in ci for clang.