cpu: aarch64: Fix C_graph_fusions_cpu test #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:cpu-aarch64
theComputeKid
approved these changes
Sep 30, 2024
mgouicem
approved these changes
Sep 30, 2024
|
COuld you please run clang-format on your patch? it seems lightweight scans are flagging violations in src/cpu/aarch64/matmul/brgemm_matmul_utils.cpp. |
Radu2k
force-pushed
the
fix_graph_fusions_cpu_test
branch
2 times, most recently
from
ca84f2e to
cb2f306
Compare
Remove asserts in brgemm_matmul_utils.cpp to make test_benchdnn_modeC_graph_fusions_cpu fail or pass. The datatype support should be checked in check_datatype. This has been renamed as well from check_isa_with_datatype to check_datatype.
Radu2k
force-pushed
the
fix_graph_fusions_cpu_test
branch
from
cb2f306 to
8bc71ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove asserts in brgemm_matmul_utils.cpp to make
test_benchdnn_modeC_graph_fusions_cpu fail or pass. The datatype support should be checked in
check_datatype. This has been renamed as well from check_isa_with_datatype to check_datatype.
Description
By enabling all graph API tests on AArch64 as a follow-up of this change (#2099 (comment)) unveiled that
ctest -R "test_benchdnn_modeC_graph_fusions_cpu"failed due to the assets on lines 323, 324 and 325 insrc/cpu/aarch64/matmul/brgemm_matmul_utils.cpp.The test segfaulted because
pick_blocked_B_layoutis called before the init, when the object is constructed. These datatypes are checked in the init and return status unimplemented.This behaviour should be changed to calling
pick_blocked_B_layoutin configure after init has passed.Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?Bug fixes