generic: SYCL: convolution/deconvolution/softmax: add missing checks #2146
+28
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:gpu-generic
mgouicem
approved these changes
Oct 4, 2024
avmanerikar
approved these changes
Oct 4, 2024
sgeor255
reviewed
Oct 7, 2024
src/gpu/generic/sycl/ref_softmax.hpp
Outdated
| @@ -48,6 +48,7 @@ struct ref_sycl_softmax_fwd_t : public gpu::generic::sycl::primitive_t { | |||
| && sycl_post_ops_t::post_ops_ok(attr(), true, false) | |||
| && set_default_formats() == status::success | |||
| && attr_.set_default_formats(dst_md()) == status::success | |||
| && check_formats(src_md(), dst_md()) | |||
There was a problem hiding this comment.
I believe in the backward pass we should check diff_src, diff_dst & dst, src is not used in the backward pass.
mgouicem
reviewed
Oct 7, 2024
mgouicem
reviewed
Oct 7, 2024
|
Could you please resolve the conflict? (I think it is just a matter of adding both checks on scales_dt and algo, but would prefer if you could check :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some previously missing checks on the SYCL implementations of convolution, deconvolution and softmax.