Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: apply commit msg check to all commits #2155

Merged
merged 1 commit into from
Oct 10, 2024
Merged

github: apply commit msg check to all commits #2155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions .github/automation/pr-title-check.py → .github/automation/commit-msg-check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

# *******************************************************************************
# Copyright 2024 Arm Limited and affiliates.
# Copyright 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand All @@ -18,7 +19,7 @@
# *******************************************************************************

import argparse

import subprocess

# * Ensuring the scopes end in colon and same level scopes are comma delimited.
# TODO: Limit scopes to an acceptable list of tags.
Expand Down Expand Up @@ -61,12 +62,20 @@ def __numCharacterCheck(msg: str):

def main():
parser = argparse.ArgumentParser()
parser.add_argument("msg", help="Commit message to check.")
parser.add_argument("head", help="Head commit of PR branch")
parser.add_argument("base", help="Base commit of PR branch")
args = parser.parse_args()
msg: str = args.msg
print(f"msg: {msg}")
__numCharacterCheck(msg)
__scopeCheck(msg)
base: str = args.base
head: str = args.head

commit_range = base + ".." + head
messages = subprocess.run(["git", "rev-list", "--ancestry-path", commit_range, "--format=oneline"], capture_output=True, text=True).stdout

for i in messages.splitlines():
commit_msg=i.split(' ', 1)[1]
print(f"msg: {commit_msg}")
__numCharacterCheck(commit_msg)
__scopeCheck(commit_msg)


if __name__ == "__main__":
Expand Down
11 changes: 9 additions & 2 deletions .github/workflows/pr-check.yml → .github/workflows/commit-msg-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# *******************************************************************************
# Copyright 2024 Arm Limited and affiliates.
# Copyright 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand All @@ -24,10 +25,16 @@ on:
# Declare default permissions as read only.
permissions: read-all

# Kill stale checks
concurrency:
group: ${{ github.ref }}
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}

jobs:
title:
if: github.repository == 'oneapi-src/oneDNN'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Pass pull request title through script.
run: python3 ./.github/automation/pr-title-check.py "${{ github.event.pull_request.title }}"
- name: Pass pull request commit messages through script.
run: python3 ./.github/automation/commit-msg-check.py "${{ github.event.pull_request.head.sha }}" "${{ github.event.pull_request.base.sha }}"
Loading