generic: skip unsupported examples #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgeor255
changed the title
github-actions
bot
added
the
platform:gpu-generic
sgeor255
force-pushed
the
svet/example-fixes
branch
from
996e949 to
000f8b0
Compare
|
Thanks for the PR @sgeor255. It seems clang-format is picking on src/gpu/generic/sycl/ref_convolution.cpp:139 (it seems to expect a line break before return statement). Could you run clang-format on that file please? |
|
make test |
mgouicem
approved these changes
Oct 17, 2024
sgeor255
force-pushed
the
svet/example-fixes
branch
from
000f8b0 to
d725d89
Compare
t4c1
approved these changes
Oct 18, 2024
sgeor255
force-pushed
the
svet/example-fixes
branch
2 times, most recently
from
1d2d20d to
e7a827d
Compare
sgeor255
force-pushed
the
svet/example-fixes
branch
from
e7a827d to
7c36b70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR skips the unsupported examples on generic vendor and fixes an issue in deconvolution where problems post-ops were incorrectly returning unimplemented (and as a result the deconvolution example was failing).
This PR is currently on top of #2159 (996e949 contains the new changes). I will rebase it on main when #2159 is merged.