Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu: aarch64: fix bug in make softmax ops use stateless ACL interface #2178

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

taoye9
Copy link
Contributor

@taoye9 taoye9 commented Oct 22, 2024

Description

A patch to fix bug in recently merged PR #2136.

Checklist

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

@taoye9 taoye9 force-pushed the feat-stateless-softmax-hot-fix branch from 6c72a91 to 8ca34a1 Compare October 22, 2024 11:23
@taoye9 taoye9 marked this pull request as ready for review October 22, 2024 11:24
@taoye9 taoye9 requested a review from a team as a code owner October 22, 2024 11:24
@Sqvid
Copy link
Contributor

Sqvid commented Oct 22, 2024

Remove the change-id

@taoye9 taoye9 force-pushed the feat-stateless-softmax-hot-fix branch from 8ca34a1 to 22d3f51 Compare October 22, 2024 12:10
Copy link
Contributor

@Radu2k Radu2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@taoye9
Copy link
Contributor Author

taoye9 commented Oct 23, 2024

ci fails due to other issues, we might need to merge this PR first: #2176

@taoye9 taoye9 force-pushed the feat-stateless-softmax-hot-fix branch from 4e55ca6 to 6945f6a Compare October 23, 2024 14:50
@taoye9
Copy link
Contributor Author

taoye9 commented Oct 24, 2024

hi, @mgouicem this pr passes ci tests, could you please merge it at your convenience?

@dzarukin dzarukin merged commit a80d41e into uxlfoundation:main Oct 24, 2024
23 of 24 checks passed
@vpirogov vpirogov added this to the v3.7 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants