generic: conv: deconv: reduce kernel argument size #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanoToni
approved these changes
Oct 23, 2024
github-actions
bot
added
the
platform:gpu-generic
sgeor255
force-pushed
the
conv-deconv-arg-size
branch
from
d105816 to
729ece5
Compare
|
make test |
densamoilov
approved these changes
Oct 24, 2024
mgouicem
approved these changes
Oct 25, 2024
|
From what I can see the CI failure is not related to the changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR splits the conf struct for Convolution primitives into 3 separate structs, reducing the argument size passed to the kernel and enabling them to run on intel devices.
Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?