cpu: aarch64: fix acl matmul dim guard for 4d tensor broadcast #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ye Tao <ye.tao@arm.com>
dzarukin
approved these changes
Oct 24, 2024
theComputeKid
approved these changes
Oct 25, 2024
|
@vpirogov can we merge this please? |
vpirogov
added
the
platform:cpu-aarch64
|
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix addresses a corner case that causes a segfault in AArch64 matmul. Since this shape wasn't covered in the test cases, I have also updated tests/benchdnn/inputs/matmul/shapes_4d.
For now, we simply redispatch when this shape is encountered and will look for a better solution in the future.
Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?