Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: cpu: aarch64: Enable jit bf16 -> f32 reorder #2206

Merged
merged 1 commit into from
Nov 19, 2024
Merged

src: cpu: aarch64: Enable jit bf16 -> f32 reorder #2206

merged 1 commit into from
Nov 19, 2024

Conversation

aditew01
Copy link
Contributor

@aditew01 aditew01 commented Nov 7, 2024

Description

This enables jit:uni reorder for dtype-> bf16 -> f32

Checklist

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit? - Yes
  • Have you formatted the code using clang-format? - Yes

Performance improvements

Adding a small testcase logs to demonstrate perf numbers before and after.

TC: ONEDNN_VERBOSE=all ./benchdnn --reorder --sdt=bf16 --ddt=f32 --mode=p 1x4096x4096

(new) jit:any :

onednn_verbose,v1,primitive,exec,cpu,reorder,jit:uni,undef,src:bf16::blocked:abc::f0 dst:f32::blocked:abc::f0,,,1x4096x4096,0.493896

(old) simple:any :

onednn_verbose,v1,primitive,exec,cpu,reorder,simple:any,undef,src:bf16::blocked:abc::f0 dst:f32::blocked:abc::f0,,,1x4096x4096,11.9778

@aditew01 aditew01 requested review from a team as code owners November 7, 2024 13:51
@mgouicem
Copy link
Contributor

mgouicem commented Nov 7, 2024

Thanks for the PR. Please rename the commit message to adhere to the oneDNN coding guideline.

@mgouicem mgouicem added the platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 label Nov 7, 2024
@aditew01 aditew01 force-pushed the adi/jit_bf16_reorder branch from c33f3bf to da22a77 Compare November 7, 2024 14:34
@aditew01 aditew01 requested a review from mgouicem November 8, 2024 11:52
@aditew01
Copy link
Contributor Author

aditew01 commented Nov 8, 2024

cc: @theComputeKid

@aditew01
Copy link
Contributor Author

cc: @Sqvid

Radu2k
Radu2k approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@Radu2k Radu2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aditew01
Copy link
Contributor Author

cc: @mgouicem

@spalicki spalicki merged commit 743211b into uxlfoundation:main Nov 19, 2024
24 checks passed
Radu2k pushed a commit to Radu2k/oneDNN that referenced this pull request Dec 2, 2024
@aditew01 @Radu2k
src: cpu: aarch64: Enable jit bf16 -> f32 reorder (uxlfoundation#2206)
4158d54
@Radu2k Radu2k mentioned this pull request Dec 2, 2024
Merged
Radu2k pushed a commit to Radu2k/oneDNN that referenced this pull request Dec 2, 2024
@aditew01 @Radu2k
src: cpu: aarch64: Enable jit bf16 -> f32 reorder (uxlfoundation#2206)
872ecac
mgouicem pushed a commit that referenced this pull request Dec 4, 2024
@aditew01 @mgouicem
src: cpu: aarch64: Enable jit bf16 -> f32 reorder (#2206)
917dd13
@vpirogov vpirogov added this to the v3.7 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Radu2k Radu2k Radu2k approved these changes

@theComputeKid theComputeKid theComputeKid approved these changes

@spalicki spalicki spalicki approved these changes

@mgouicem mgouicem Awaiting requested review from mgouicem

Assignees
No one assigned
Labels
platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64
Projects
None yet
Milestone
v3.7
Development

Successfully merging this pull request may close these issues.
6 participants
@aditew01 @mgouicem @Radu2k @theComputeKid @spalicki @vpirogov