generic:sycl: Inner Product FWD #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
sgeor255
force-pushed
the
atharva/inner_product_fwd
branch
2 times, most recently
from
e9de548 to
0754aa7
Compare
Rbiessy
approved these changes
Dec 11, 2024
ShanoToni
approved these changes
Dec 18, 2024
|
|
||
| primitive_desc_iterator_t it(engine, | ||
| reinterpret_cast<op_desc_t *>(&matmul_desc), &matmul_attr, nullptr); | ||
| if (!it.is_initialized()) return status::invalid_arguments; |
There was a problem hiding this comment.
Seems the correct status to be returned here is status::out_of_memory
There was a problem hiding this comment.
The most likely reason for the iterator to fail to return a primitive_desc is unimplemented. But indeed, we don't have a way to forward the a status from the iterator.
There was a problem hiding this comment.
Done, it seems most of the similar patterns return out_of_memory indeed.
mgouicem
reviewed
Dec 18, 2024
mgouicem
approved these changes
Dec 18, 2024
Co-authored-by: Atharva Dubey <atharvadubey26@gmail.com>
Rbiessy
force-pushed
the
atharva/inner_product_fwd
branch
from
0754aa7 to
4b84d79
Compare
vpirogov
approved these changes
Dec 18, 2024
Rbiessy
reviewed
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?