Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failing tests for matmul and convolution #2285

Closed
wants to merge 2 commits into from

Conversation

renato-arantes
Copy link
Contributor

Description

Tests test_benchdnn_modeC_conv_ci_cpu and test_benchdnn_modeC_matmul_ci_cpu are failing, and this patch fixes them.

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

@renato-arantes renato-arantes requested a review from a team as a code owner December 18, 2024 15:04
@renato-arantes renato-arantes changed the title Fix upstream CI failing testfor matmul and conv Fix upstream CI failing tests for matmul and conv Dec 18, 2024
@renato-arantes renato-arantes changed the title Fix upstream CI failing tests for matmul and conv Fix upstream CI failing tests for matmul and convolution Dec 18, 2024
@github-actions github-actions bot added the platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 label Dec 18, 2024
Copy link
Contributor

@theComputeKid theComputeKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no upstream CI, only CI.

@vpirogov
Copy link
Contributor

Tests with GCC on c6 instances are still failing.

@renato-arantes renato-arantes changed the title Fix upstream CI failing tests for matmul and convolution Fix CI failing tests for matmul and convolution Dec 19, 2024
Co-authored-by: Vadim Pirogov <vadim.o.pirogov@intel.com>
@theComputeKid
Copy link
Contributor

Can you also change the title of the commits, thanks! Perhaps squash the second commit into the first one.

@renato-arantes
Copy link
Contributor Author

We must close this PR because we had to revert PR #2198.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants