-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build acl cache sequentially #2388
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "dependencies": { | ||
| "acl": "v24.11.1", | ||
| "gcc": "13", | ||
| "clang": "17" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| # ******************************************************************************* | ||
| # Copyright 2025 Arm Limited and affiliates. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # ******************************************************************************* | ||
|
|
||
| name: "Build ACL cache" | ||
|
|
||
| #* To avoid duplicate jobs running when both push and PR is satisfied, we use this: | ||
| #* https://github.com/orgs/community/discussions/26940#discussioncomment-5686753 | ||
| on: | ||
| workflow_call: | ||
| workflow_dispatch: | ||
|
|
||
| # Declare default permissions as read only. | ||
| permissions: read-all | ||
|
|
||
| jobs: | ||
| # Cache is built sequentially to avoid cache-hit race conditions | ||
| build-cache: | ||
| strategy: | ||
| max-parallel: 1 | ||
| matrix: | ||
| config: [ | ||
| { name: MacOS, label: macos-14, threading: SEQ, toolset: clang, build: Release }, | ||
| { name: c6g, label: ah-ubuntu_22_04-c6g_2x-50, threading: OMP, toolset: clang, build: Debug }, | ||
| { name: c6g, label: ah-ubuntu_22_04-c6g_2x-50, threading: OMP, toolset: gcc, build: Release } | ||
| ] | ||
|
|
||
| name: ${{ matrix.config.name }}, ${{ matrix.config.toolset }}, ${{ matrix.config.threading }}, ${{ matrix.config.build }} | ||
| runs-on: ${{ matrix.config.label }} | ||
| steps: | ||
| - name: Checkout oneDNN | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| path: oneDNN | ||
|
|
||
| - name: Read version file | ||
| id: get-versions | ||
| run: | | ||
| content=`cat ${{ github.workspace }}/oneDNN/.github/automation/ci-aarch64.json` | ||
| content="${content//[$'\t\r\n$ ']}" | ||
| echo "output=$content" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Clone ACL | ||
| run: ${{ github.workspace }}/oneDNN/.github/automation/build_acl.sh | ||
| env: | ||
| ACL_ACTION: clone | ||
| ACL_ROOT_DIR: ${{ github.workspace }}/ComputeLibrary | ||
| ACL_VERSION: ${{ fromJson(steps.get-versions.outputs.output).dependencies.acl }} | ||
|
|
||
| - name: Get ACL commit hash for cache key | ||
| id: get_acl_commit_hash | ||
| run: (cd ${{ github.workspace }}/ComputeLibrary && echo "ACLCommitHash=$(git rev-parse --short HEAD)") >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Get system name | ||
| id: get_system_name | ||
| run: (echo "SystemName=$(uname)") >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Restore cached ACL | ||
| id: cache-acl-restore | ||
| uses: actions/cache/restore@v4 | ||
| with: | ||
| key: ${{ steps.get_system_name.outputs.SystemName }}-acl-${{ matrix.config.toolset }}-${{ matrix.config.build }}-${{ steps.get_acl_commit_hash.outputs.ACLCommitHash }} | ||
| path: ${{ github.workspace }}/ComputeLibrary/build | ||
|
|
||
| - name: Install Scons (MacOS) | ||
| if: ${{ matrix.config.name == 'MacOS' && (steps.cache-acl-restore.outputs.cache-hit != 'true') }} | ||
| run: brew install scons | ||
|
|
||
| - name: Install scons (Linux) | ||
| if: ${{ matrix.config.name != 'MacOS' && (steps.cache-acl-restore.outputs.cache-hit != 'true') }} | ||
| run: | | ||
| sudo apt update -y | ||
| sudo apt install -y scons | ||
|
|
||
| - if: ${{ startsWith(matrix.config.label,'ah-ubuntu') && (matrix.config.threading == 'OMP') && (steps.cache-acl-restore.outputs.cache-hit != 'true') }} | ||
| name: Install openmp | ||
| run: | | ||
| sudo apt install -y libomp-dev | ||
|
|
||
| - if: ${{ startsWith(matrix.config.label,'ah-ubuntu') && (matrix.config.toolset == 'gcc') && (steps.cache-acl-restore.outputs.cache-hit != 'true') }} | ||
| name: Install gcc | ||
| run: | | ||
| sudo add-apt-repository ppa:ubuntu-toolchain-r/test -y | ||
| sudo apt update -y | ||
| sudo apt install -y g++-${{ fromJson(steps.get-versions.outputs.output).dependencies.gcc }} | ||
|
|
||
| - if: ${{ startsWith(matrix.config.label,'ah-ubuntu') && (matrix.config.toolset == 'clang') && (steps.cache-acl-restore.outputs.cache-hit != 'true') }} | ||
| name: Install clang | ||
| uses: KyleMayes/install-llvm-action@e0a8dc9cb8a22e8a7696e8a91a4e9581bec13181 | ||
| with: | ||
| version: ${{ fromJson(steps.get-versions.outputs.output).dependencies.clang }} | ||
|
|
||
| - name: Build ACL | ||
| if: ${{ steps.cache-acl-restore.outputs.cache-hit != 'true' }} | ||
| run: ${{ github.workspace }}/oneDNN/.github/automation/build_acl.sh | ||
| env: | ||
| ACL_ACTION: build | ||
| ACL_ROOT_DIR: ${{ github.workspace }}/ComputeLibrary | ||
| ACL_THREADING: ${{ matrix.config.threading }} | ||
| BUILD_TOOLSET: ${{ matrix.config.toolset }} | ||
| ACL_BUILD_TYPE: ${{ matrix.config.build }} | ||
| GCC_VERSION: ${{ fromJson(steps.get-versions.outputs.output).dependencies.gcc }} | ||
|
|
||
| - name: Save ACL in cache | ||
| id: cache-acl_build-save | ||
| if: ${{ steps.cache-acl-restore.outputs.cache-hit != 'true' }} | ||
| uses: actions/cache/save@v4 | ||
| with: | ||
| key: ${{ steps.get_system_name.outputs.SystemName }}-acl-${{ matrix.config.toolset }}-${{ matrix.config.build }}-${{ steps.get_acl_commit_hash.outputs.ACLCommitHash }} | ||
| path: ${{ github.workspace }}/ComputeLibrary/build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did CMake not work at all? It is surprising that it was building fine before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, wasn't working for gcc or macOS, I imagine you hadn't changed ACL versions after switching to cmake so we were always reusing the cached build