gpu: generic: Fix matmul with dropout #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:gpu-generic
AD2605
approved these changes
Feb 12, 2025
Rbiessy
approved these changes
Feb 12, 2025
s-Nick
changed the title
The signature of dropout function doesn't respect arguments type it receives. Due to implicit casting, it doesn't appear as an issue but adding dropout to matmul would make it fail. This commit fixes the issue. Signed-off-by: nscipione <nicolo.scipione@codeplay.com>
s-Nick
force-pushed
the
fix_generic_matmul_dropout
branch
from
16e8f66 to
0ace8b9
Compare
|
make test |
sgeor255
approved these changes
Feb 12, 2025
|
make test |
|
make test |
|
CI failures are unrelated to this PR |
s-Nick
added a commit
to s-Nick/oneDNN
that referenced
this pull request
Feb 24, 2025
Signed-off-by: nscipione <nicolo.scipione@codeplay.com>
3 tasks
vpirogov
pushed a commit
that referenced
this pull request
Feb 25, 2025
Signed-off-by: nscipione <nicolo.scipione@codeplay.com>
vpirogov
changed the title
manaalmj
pushed a commit
to manaalmj/oneDNN
that referenced
this pull request
Mar 4, 2025
Signed-off-by: nscipione <nicolo.scipione@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The signature of dropout function doesn't respect arguments type it receives. Due to implicit casting, it doesn't appear as an issue but adding dropout to matmul would make it fails.
This patch fixes the issue.
To reproduce, run the following command on main:
./tests/benchdnn/benchdnn --mode-modifier=P --matmul --engine=gpu --dt=bf16:bf16:bf16 --stag=ab --dtag=ab --attr-dropout=0.5:12345678 100x1:1x1Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?Bug fixes