common, xe: fix missing -cl-intel-greater-than-4GB-buffer-required OpenCL flag #2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:gpu-intel
rjoursler
force-pushed
the
rjoursle/fix_concat
branch
3 times, most recently
from
1005547 to
bfaf989
Compare
echeresh
approved these changes
Feb 18, 2025
rjoursler
force-pushed
the
rjoursle/fix_concat
branch
2 times, most recently
from
707336e to
13a3261
Compare
|
make test |
mgouicem
reviewed
Feb 26, 2025
rjoursler
force-pushed
the
rjoursle/fix_concat
branch
from
13a3261 to
71de94e
Compare
The behavior of returning 0 when offset0 is set is not aligned with how primitives check for large buffer support.
Stateful loads cannot address buffers that exceed 4GB in offset from the base pointer.
rjoursler
force-pushed
the
rjoursle/fix_concat
branch
from
71de94e to
19ab2ca
Compare
mgouicem
approved these changes
Feb 27, 2025
|
make test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When offset0 is set, the maximum offset addressed by an OpenCL kernel is
offset0 + buffer_size. If this value exceeds a 4GB offset, stateless addressing must be used, which requires setting the-cl-intel-greater-than-4GB-buffer-requiredflag. This PR adds the missing checks against offset0. This required modifyingmemory_desc_wrapper::size()to return an appropriate size whenoffset0is set.Fixes MFDNN-13205.