Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: clang-tidy: speed-up clang-tidy #2758

Merged
merged 61 commits into from
Mar 11, 2025
Merged

ci: clang-tidy: speed-up clang-tidy #2758

merged 61 commits into from
Mar 11, 2025

Conversation

hmaciak
Copy link
Contributor

@hmaciak hmaciak commented Feb 26, 2025

This PR is to speed up clang-tidy builds by building only changed files.

@hmaciak hmaciak requested a review from a team as a code owner February 26, 2025 12:22
@hmaciak hmaciak marked this pull request as draft February 26, 2025 12:22
@github-actions github-actions bot added the devops Github automation label Feb 26, 2025
@github-actions github-actions bot added the platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 label Feb 26, 2025
@github-actions github-actions bot added the platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 label Feb 27, 2025
@github-actions github-actions bot added the component:api Codeowner: @oneapi-src/onednn-arch label Feb 27, 2025
@github-actions github-actions bot removed the platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 label Mar 6, 2025
hmaciak and others added 3 commits March 7, 2025 10:33
@github-actions github-actions bot added platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 labels Mar 7, 2025
@github-actions github-actions bot removed platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 labels Mar 7, 2025
@hmaciak hmaciak requested a review from vpirogov March 7, 2025 10:42
@vpirogov vpirogov removed request for a team March 7, 2025 18:24
@vpirogov
Copy link
Contributor

vpirogov commented Mar 7, 2025

Few minor improvements looking at the results on a test PR:

  1. clang-tidy version matters for the results, let's add a print with version like we do for clang-format.
  2. Check should fail on errors as well, now it passes.
  3. An empty line before 'Analyzing' would improve readability.

@github-actions github-actions bot added the platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 label Mar 10, 2025
@github-actions github-actions bot removed the platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 label Mar 10, 2025
@hmaciak hmaciak requested a review from theComputeKid March 10, 2025 12:58
@hmaciak
Copy link
Contributor Author

hmaciak commented Mar 11, 2025

ping @theComputeKid

@Sqvid
Copy link
Contributor

Sqvid commented Mar 11, 2025

Hi @hmaciak thank you for these changes. @theComputeKid is away from the office for the next few weeks so he may or may not be able to provide a timely review. I've approved the PR for now. Thanks.

@hmaciak hmaciak merged commit fecc24b into main Mar 11, 2025
7 of 8 checks passed
@hmaciak hmaciak deleted the hmaciak/speed_clang-tidy branch March 11, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Github automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants